Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename l1{-,_}provider for consistency #1979

Merged
merged 1 commit into from
Nov 12, 2024
Merged

chore: rename l1{-,_}provider for consistency #1979

merged 1 commit into from
Nov 12, 2024

Conversation

giladchase
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [30.402 ms 30.482 ms 30.562 ms]
change: [-2.4394% -1.7677% -1.2607%] (p = 0.00 < 0.05)
Performance has improved.

@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.15%. Comparing base (e3165c4) to head (0b51f5c).
Report is 328 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1979       +/-   ##
===========================================
+ Coverage   40.10%   76.15%   +36.05%     
===========================================
  Files          26      373      +347     
  Lines        1895    39857    +37962     
  Branches     1895    39857    +37962     
===========================================
+ Hits          760    30355    +29595     
- Misses       1100     7241     +6141     
- Partials       35     2261     +2226

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giladchase giladchase requested a review from elintul November 12, 2024 12:29
elintul
elintul approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@giladchase giladchase merged commit e61c7ce into main Nov 12, 2024
21 checks passed
@giladchase giladchase deleted the gilad/rename-dirs branch November 12, 2024 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elintul elintul elintul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladchase @reviewable-StarkWare @elintul